Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve Table Filters for both PPR/MHR #2005

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

cameron-eyds
Copy link
Collaborator

@cameron-eyds cameron-eyds commented Aug 21, 2024

Issue #: /bcgov/entity#21326

Description of changes:

  • Refactors to preserve Table Filters for both PPR and MHR Registration Table instances
  • Preserves ALL filters throughout filings, route changes, registrations etc.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the PPR license (Apache 2.0).

@cameron-eyds
Copy link
Collaborator Author

/gcbrun

Copy link
Collaborator

@flutistar flutistar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-2005-ui0ygly2.web.app

Copy link
Collaborator

@doug-lovett doug-lovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@cameron-eyds
Copy link
Collaborator Author

/gcbrun

@bcregistry-sre
Copy link
Collaborator

Temporary Url for review: https://bcregistry-assets-dev--pr-2005-ui0ygly2.web.app

@cameron-eyds cameron-eyds merged commit b71479b into bcgov:main Aug 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants